Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supported cypress for stored procedure and data models #13312

Merged
merged 7 commits into from
Sep 25, 2023
Merged

supported cypress for stored procedure and data models #13312

merged 7 commits into from
Sep 25, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #12998

  • added cypress for Stored Procedure and Data Model

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 22, 2023
@Ashish8689 Ashish8689 self-assigned this Sep 22, 2023
@Ashish8689 Ashish8689 temporarily deployed to test September 22, 2023 12:20 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 22, 2023 12:20 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 22, 2023 12:20 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 22, 2023 12:20 — with GitHub Actions Inactive
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
 50.67% (22484/44371) 31.78% (8339/26240) 31.68% (2595/8192)

chirag-madlani
chirag-madlani previously approved these changes Sep 22, 2023
View reviewed changes
@cypress
Copy link

cypress bot commented Sep 22, 2023 •
edited
Loading

26 failed tests on run #30551 ↗︎

26 389 52 1 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge branch 'main' into search-indexes-cypress
Project: openmetadata Commit: c807d634e6
Status: Failed Duration: 01:57 💡
Started: Sep 25, 2023 12:00 PM Ended: Sep 25, 2023 1:02 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Ashish8689 Ashish8689 temporarily deployed to test September 22, 2023 19:55 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 22, 2023 19:55 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 07:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 07:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 07:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 07:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 09:25 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 09:25 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 09:25 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 11:37 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 11:37 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 11:37 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 25, 2023 11:37 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 8b37b92 into main Sep 25, 2023
18 of 24 checks passed
@chirag-madlani chirag-madlani deleted the search-indexes-cypress branch September 25, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Stored Procedures as another entity under Database Schema
2 participants
@Ashish8689 @chirag-madlani